]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
modemManager: Look for property on correct object
authorCosimo Cecchi <cosimoc@gnome.org>
Sat, 14 Mar 2020 21:42:43 +0000 (14:42 -0700)
committerFlorian Müllner <fmuellner@gnome.org>
Sat, 14 Mar 2020 21:59:59 +0000 (22:59 +0100)
The SignalQuality property is defined on the GDBusProxy, not the modem
JS object.
Fix this runtime warning:

JS WARNING: [resource:///org/gnome/shell/misc/modemManager.js 252]: reference to undefined property "SignalQuality"
JS ERROR: TypeError: this.SignalQuality is undefined
_reloadSignalQuality@resource:///org/gnome/shell/misc/modemManager.js:252:34
_init@resource:///org/gnome/shell/misc/modemManager.js:234:14
NMDeviceModem@resource:///org/gnome/shell/ui/status/network.js:517:34
_deviceAdded@resource:///org/gnome/shell/ui/status/network.js:1755:27

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1097

js/misc/modemManager.js

index 21e49e81c522b986e01a61e30d535b3704c89609..4cc810bbb63e2b58aba14762298547094233333a 100644 (file)
@@ -249,7 +249,7 @@ var BroadbandModem = GObject.registerClass({
     }
 
     _reloadSignalQuality() {
-        let [quality, recent_] = this.SignalQuality;
+        let [quality, recent_] = this._proxy.SignalQuality;
         this._setSignalQuality(quality);
     }